Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CMake] Update CMake minimum required version to suppress deprecation warnings. #569

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CMake] Update CMake minimum required version to suppress deprecation warnings. #569

wants to merge 1 commit into from

Conversation

harrisonGPU
Copy link

When I use the following CMake build commands to build the taco compiler, I encounter a warning:

cmake -GNinja .. \
	   -DCMAKE_BUILD_TYPE=Debug \
	   -DCMAKE_EXPORT_COMPILE_COMMANDS=ON

Here is the warning log:

CMake Deprecation Warning at apps/tensor_times_vector/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- Submodule update
Submodule 'python_bindings/pybind11' (https://github.com/pybind/pybind11) registered for path 'python_bindings/pybind11'
Submodule 'test/bats' (https://github.com/bats-core/bats-core) registered for path 'test/bats'
Cloning into '/home/harrison/Projects/taco/python_bindings/pybind11'...
Cloning into '/home/harrison/Projects/taco/test/bats'...
Submodule path 'python_bindings/pybind11': checked out '8de7772cc72daca8e947b79b83fea46214931604'
Submodule path 'test/bats': checked out 'dcaec03e32e0b152f8ef9cf14b75296cf5caeaff'
-- Configuring done (49.2s)
-- Generating done (0.0s)
-- Build files have been written to: /home/harrison/Projects/taco/build

Therefore, I think we need to upgrade the version specified in apps/tensor_times_vector/CMakeLists.txt.

@harrisonGPU
Copy link
Author

harrisonGPU commented Nov 20, 2024 •
edited
Loading

@weiya711 @zhang677 , please take a look. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harrisonGPU